[19.0][FIX] ..import_camt: fix error when node is an empty element#936
Open
[19.0][FIX] ..import_camt: fix error when node is an empty element#936
Conversation
OCA-git-bot
added
series:19.0
mod:account_statement_import_camt
NL66278
force-pushed
the
19.0-fix-camt-empty-node-text
branch
2 times, most recently
from
9272f15 to
2570f44
Compare
Import would have an exception when encountering '<RmtInf><Ustrd /></RmtInf>':
File "/home/odooedprd19/odoo/auto/addons/account_statement_import_camt/wizard/account_statement_import_camt_parser.py", line 60, in parse_transaction_details
self.add_value_from_node(
~~~~~~~~~~~~~~~~~~~~~~~~^
ns,
^^^
...<8 lines>...
join_str="\n",
^^^^^^^^^^^^^^
)
^
File "/home/odooedprd19/odoo/auto/addons/account_statement_import_camt/wizard/account_statement_import_camt_parser.py", line 53, in add_value_from_node
attr_value = join_str.join([x.text for x in found_node])
TypeError: sequence item 0: expected str instance, NoneType found
NL66278
force-pushed
the
19.0-fix-camt-empty-node-text
branch
from
2570f44 to
5e763e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import would have an exception when encountering
<RmtInf><Ustrd /></RmtInf>:File "/home/odooedprd19/odoo/auto/addons/account_statement_import_camt/wizard/account_statement_import_camt_parser.py", line 60, in parse_transaction_details
self.add_value_from_node(
~~~~~~~~~~~~~~~~~~~~~~~~^
ns,
^^^
...<8 lines>...
join_str="\n",
^^^^^^^^^^^^^^
)
^
File "/home/odooedprd19/odoo/auto/addons/account_statement_import_camt/wizard/account_statement_import_camt_parser.py", line 53, in add_value_from_node
attr_value = join_str.join([x.text for x in found_node])
TypeError: sequence item 0: expected str instance, NoneType found